Differential D29678

Fix incorrect colours in the KNS Quick messagebox
ClosedPublic
Actions

Authored by leinir on May 12 2020, 1:45 PM.

Details

Reviewers
bugseforuns
ngraham
Group Reviewers
Frameworks
KNewStuff
Plasma
Commits
R304:5ce4d1a29b96: Fix incorrect colours in the KNS Quick messagebox
Summary

Explicitly set the colours used in the messagebox' content item,
as the theme does not propagate to the simpler items, only to
those based on top of QtQuick Controls.

BUG:421270

Test Plan

Ensure you are using a dark colour scheme. Provoke an error dialog in any KNewStuff Quick dialog, and see that this patch makes the error message colour turn from a near-invisible text on a dark background (as shown in https://bugs.kde.org/show_bug.cgi?id=421270) to a visible text on a dark background.

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.May 12 2020, 1:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 12 2020, 1:45 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.May 12 2020, 1:45 PM
leinir edited the test plan for this revision. (Show Details)May 12 2020, 1:50 PM
leinir added reviewers: Frameworks, KNewStuff, Plasma, bugseforuns.
ngraham added a subscriber: ngraham.May 13 2020, 2:16 PM

Does this even need to be a TextEdit? Or is that to get mouse-selectability for the error text? If so, +1 but please add comments indicating this reason.

leinir added a comment.May 13 2020, 2:22 PM
In D29678#670125, @ngraham wrote:

Does this even need to be a TextEdit? Or is that to get mouse-selectability for the error text? If so, +1 but please add comments indicating this reason.

That is precisely what it's for - i'll add a comment to that effect :)

leinir updated this revision to Diff 82744.May 13 2020, 2:24 PM

Address comment by @ngraham

  • Add a comment for the purpose of the control being a TextEdit
ngraham accepted this revision.May 13 2020, 6:42 PM
This revision is now accepted and ready to land.May 13 2020, 6:42 PM
Closed by commit R304:5ce4d1a29b96: Fix incorrect colours in the KNS Quick messagebox (authored by leinir). · Explain WhyMay 13 2020, 7:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82791

View Options

src/qtquick/qml/private/MessageBoxSheet.qml

Loading...