Differential D29675

initialize bools to false by default
ClosedPublic
Actions

Authored by sitter on May 12 2020, 10:29 AM.

Details

Reviewers
davidedmundson
apol
Commits
R871:c517b795936f: initialize bools to false by default
Summary

This should fix random 113 errors (user_not_insider) coming out of the api

I can't really reproduce the problem but by setting the bools explicitly
true and seeing as they were previously not set explicitly they could very
well end up true accidentally.
To fix this let's set them explicitly false.

BUG: 421187
FIXED-IN: 5.18.6

Test Plan

hoping for the best!
tests still pass tho

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.May 12 2020, 10:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 12 2020, 10:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.May 12 2020, 10:29 AM
apol accepted this revision.May 12 2020, 11:13 AM
This revision is now accepted and ready to land.May 12 2020, 11:13 AM
Closed by commit R871:c517b795936f: initialize bools to false by default (authored by sitter). · Explain WhyMay 12 2020, 11:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82651

View Options

src/bugzillaintegration/libbugzilla/clients/commands/newattachment.h

Loading...