Differential D29665

Emit Workspace::clientAdded() with AbstractClient
ClosedPublic
Actions

Authored by zzag on May 11 2020, 6:06 PM.

Details

Reviewers

cblack

Group Reviewers

KWin

Commits

R108:7b751099bfdd: Emit Workspace::clientAdded() with AbstractClient

Summary

Currently, if one wants to monitor for new X11 and Wayland clients, they
have to listen for two signals. Workspace::clientAdded() is emitted only
for X11 and Xwayland clients, while WaylandServer::shellClientAdded() is
emitted only for xdg-shell clients. Such design doesn't scale well.

As the first towards emitting Workspace::clientAdded() for new Wayland
clients, this change replaces the X11Client parameter in the clientAdded
signal with AbstractClient.

Test Plan

Tests still pass.

Diff Detail

Repository

R108 KWin

Branch

generic-client-added-signal

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26741
Build 26759: arc lint + arc unit

zzag created this revision.May 11 2020, 6:06 PM

Restricted Application added a project: KWin. · View Herald TranscriptMay 11 2020, 6:06 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.May 11 2020, 6:06 PM

Harbormaster completed remote builds in B26741: Diff 82598.May 11 2020, 6:06 PM

cblack accepted this revision.May 11 2020, 6:08 PM

This revision is now accepted and ready to land.May 11 2020, 6:08 PM

Closed by commit R108:7b751099bfdd: Emit Workspace::clientAdded() with AbstractClient (authored by zzag). · Explain WhyMay 12 2020, 5:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			debug_console.cpp (6 lines)
M			effects.cpp (6 lines)
M			scripting/workspace_wrapper.h (3 lines)
M			scripting/workspace_wrapper.cpp (15 lines)
M			workspace.h (2 lines)