Differential D29635

[kcms/keys] Make saving sync
ClosedPublic
Actions

Authored by davidre on May 11 2020, 2:17 PM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma
Commits
R119:fcb04768142f: [kcms/keys] Make saving sync
Summary

If it's async it will not save when changing modules, or quitting kcmshell, see T13140.
BUG: 421333

Test Plan

Make a change, change module in systemsettings. Changes are saved.

Diff Detail

Repository
R119 Plasma Desktop
Branch
syncSave (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26708
Build 26726: arc lint + arc unit
davidre created this revision.May 11 2020, 2:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 11 2020, 2:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.May 11 2020, 2:17 PM
davidedmundson accepted this revision.May 11 2020, 6:10 PM
This revision is now accepted and ready to land.May 11 2020, 6:10 PM
Closed by commit R119:fcb04768142f: [kcms/keys] Make saving sync (authored by davidre). · Explain WhyMay 12 2020, 6:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/keys/shortcutsmodel.cpp (71 lines)

Diff 82535

View Options

kcms/keys/shortcutsmodel.cpp

Loading...