Differential D29604

feat(akonadi): sort agents alphabetically
ClosedPublic
Actions

Authored by marcdeop on May 10 2020, 5:45 PM.

Details

Reviewers
dvratil
vkrause
Group Reviewers
KDE PIM: Junior Jobs
Commits
R165:f1fd1d418d36: feat(akonadi): sort agents alphabetically
Summary

Partially solves: https://phabricator.kde.org/T9428

This sorts alphabetically the Agents

Test Plan

Akonadi has been compiled with the patch and akonadiconsole has been launched. Everything seems to work as expected and *sorted* :-)

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marcdeop created this revision.May 10 2020, 5:45 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 10 2020, 5:45 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
marcdeop requested review of this revision.May 10 2020, 5:45 PM
marcdeop added reviewers: dvratil, vkrause.
vkrause added a comment.May 10 2020, 6:12 PM

Phabricator messed up the path (missing "src/" prefix), with that fixed it does work as expected. The result gets even better with case-insensitive sorting IMHO (d->proxy->setSortCaseSensitivity(Qt::CaseInsensitive);).

marcdeop updated this revision to Diff 82455.May 10 2020, 6:17 PM

I re-uploaded the patch. Things seems to be better regarding the paths.

Also added d->proxy->setSortCaseSensitivity(Qt::CaseInsensitive); :-)

dvratil accepted this revision.May 11 2020, 5:51 AM

Nice, thanks!

This revision is now accepted and ready to land.May 11 2020, 5:51 AM
vkrause added a comment.May 11 2020, 4:01 PM

If you don't have commit access I can land this for you, I'd need a name and email address to use in the Git commit though.

marcdeop added a comment.May 11 2020, 6:10 PM
In D29604#668650, @vkrause wrote:

If you don't have commit access I can land this for you, I'd need a name and email address to use in the Git commit though.

I don't think I have commit access ;-)

Name: Marc Deop i Argemí
Email: kde@marcdeop.com

Closed by commit R165:f1fd1d418d36: feat(akonadi): sort agents alphabetically (authored by Marc Deop i Argemí <kde@marcdeop.com>, committed by vkrause). · Explain WhyMay 11 2020, 6:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82602

View Options

src/widgets/agentinstancewidget.cpp

Loading...