Add gocryptfs support
ClosedPublic

Authored by mpilia on May 10 2020, 11:55 AM.

Details

Reviewers
ivan
Group Reviewers
Plasma
Commits
R845:853b0be5a4ac: Add gocryptfs support
Summary

Implement basic support for gocryptfs backend.

BUG: 398323

Diff Detail

Repository
R845 Plasma Vault
Branch
add-gocryptfs-support (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26744
Build 26762: arc lint + arc unit
mpilia created this revision.May 10 2020, 11:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 10 2020, 11:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mpilia requested review of this revision.May 10 2020, 11:55 AM
ngraham added a subscriber: ngraham.

Very cool!

ivan requested changes to this revision.May 11 2020, 6:06 PM

Great work!

kded/ui/vaultwizardbase.h
64

Lower the priority to 1.

I don't want to have gocryptfs as the default. At least for the time being.

This revision now requires changes to proceed.May 11 2020, 6:06 PM
mpilia updated this revision to Diff 82601.May 11 2020, 6:22 PM

Fix priority for gocryptfs

mpilia added inline comments.May 11 2020, 6:24 PM
kded/ui/vaultwizardbase.h
64

Of course, sorry. For some reason I though 1 was highest priority.

ivan added inline comments.May 11 2020, 6:49 PM
kded/ui/vaultwizardbase.h
64

Heh, it was my first impression when the priority patch was contributed to Vaults. Now I'm extra careful :)

ngraham added inline comments.May 11 2020, 10:31 PM
kded/ui/vaultwizardbase.h
64

Perhaps the unintuitive nature of the numbering could be clarified with a comment in a follow-up patch

ivan accepted this revision.May 12 2020, 8:25 AM
This revision is now accepted and ready to land.May 12 2020, 8:25 AM

@ivan are you gonna land this, or should I?

ivan closed this revision.May 12 2020, 4:38 PM
ivan added a comment.May 12 2020, 4:39 PM

Done. Thanks again for the patch!