Differential D29560

Dolphin: Cleanup service settings page
ClosedPublic
Actions

Authored by alex on May 9 2020, 1:05 PM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:2b58f0457e47: Dolphin: Cleanup service settings page
Summary

Just some little things :-)

  • Refactor foreach
  • Fix minor formatting issues
  • Use auto keyword where appropiate
Test Plan

Compiles

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alex created this revision.May 9 2020, 1:05 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMay 9 2020, 1:05 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
alex requested review of this revision.May 9 2020, 1:05 PM
alex updated this revision to Diff 82367.May 9 2020, 1:10 PM

Indentation

ngraham added a comment.May 11 2020, 1:26 PM

+1 overall, though I'm not sure changing those things to auto is needed or beneficial.

src/settings/services/servicessettingspage.cpp
63

Not sure changing these to auto is needed

alex updated this revision to Diff 82592.May 11 2020, 5:32 PM

Change auto

If you are not sure about changing that bit I will just revert it :-)

alex marked an inline comment as done.May 11 2020, 5:33 PM
elvisangelaccio requested changes to this revision.May 11 2020, 5:46 PM
elvisangelaccio added a subscriber: elvisangelaccio.
elvisangelaccio added inline comments.
src/settings/services/servicessettingspage.cpp
123–124

Please no, this looks really bad.

I'd just revert all these line splittings honestly. What's the gain?

This revision now requires changes to proceed.May 11 2020, 5:46 PM
alex added inline comments.May 11 2020, 5:49 PM
src/settings/services/servicessettingspage.cpp
123–124

Sorry, I accidentally ran the automatic formatter when I made that last minor change, my bad :-(

alex updated this revision to Diff 82595.May 11 2020, 5:57 PM

Fix formatting

elvisangelaccio accepted this revision.May 11 2020, 5:57 PM
This revision is now accepted and ready to land.May 11 2020, 5:57 PM
alex marked 2 inline comments as done.May 11 2020, 5:58 PM
Closed by commit R318:2b58f0457e47: Dolphin: Cleanup service settings page (authored by alex). · Explain WhyMay 11 2020, 6:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82597

View Options

src/settings/services/servicessettingspage.h

Loading...
View Options

src/settings/services/servicessettingspage.cpp

Loading...