Differential D29512

Move core shade code to AbstractClient
ClosedPublic
Actions

Authored by zzag on May 7 2020, 4:27 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R108:44143ef7aeb9: Move core shade code to AbstractClient

Summary

In order to allow shading wayland clients, this change moves core shade
code from X11Client to AbstractClient.

Test Plan

Shading still works on X11.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.May 7 2020, 4:27 PM

Restricted Application added a project: KWin. · View Herald TranscriptMay 7 2020, 4:27 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.May 7 2020, 4:27 PM

Harbormaster completed remote builds in B26521: Diff 82220.May 7 2020, 4:27 PM

zzag edited the test plan for this revision. (Show Details)May 7 2020, 4:30 PM

Test plan works as advertised and code seems fine.

This revision is now accepted and ready to land.May 7 2020, 4:43 PM

Closed by commit R108:44143ef7aeb9: Move core shade code to AbstractClient (authored by zzag). · Explain WhyMay 7 2020, 7:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.h (30 lines)
M			abstract_client.cpp (105 lines)
M			events.cpp (17 lines)
M			tabbox/tabbox.cpp (16 lines)
M			useractions.cpp (25 lines)
M			x11client.h (19 lines)
M			x11client.cpp (65 lines)

Diff 82230

abstract_client.h

Loading...

abstract_client.cpp

Loading...

events.cpp

Loading...

tabbox/tabbox.cpp

Loading...

useractions.cpp

Loading...

x11client.h

Loading...

x11client.cpp

Loading...