Differential D29490

This removes the negative top margin, as it's already removed by the NotificationPopup
ClosedPublic
Actions

Authored by niccolove on May 6 2020, 6:02 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R120:571f0aba2fc5: This removes the negative top margin, as it's already removed by the…
Summary

The negative top margin was not necessary and causes missing round corners.

Test Plan

No visual change on master
With D29479, rounded corners should appear again

Diff Detail

Repository
R120 Plasma Workspace
Branch
fix_top_margin_of_heading (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26466
Build 26484: arc lint + arc unit
niccolove created this revision.May 6 2020, 6:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 6 2020, 6:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.May 6 2020, 6:02 PM
niccolove edited the test plan for this revision. (Show Details)May 6 2020, 6:03 PM
niccolove added a reviewer: Plasma.
niccolove edited the test plan for this revision. (Show Details)
ngraham accepted this revision.May 6 2020, 6:15 PM
This revision is now accepted and ready to land.May 6 2020, 6:15 PM
Closed by commit R120:571f0aba2fc5: This removes the negative top margin, as it's already removed by the… (authored by niccolove). · Explain WhyMay 6 2020, 7:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82129

View Options

applets/notifications/package/contents/ui/NotificationItem.qml

Loading...