This removes the negative top margin, as it's already removed by the NotificationPopup
ClosedPublic
Actions

Authored by niccolove on May 6 2020, 6:02 PM.

Details

Reviewers

ngraham

Group Reviewers

Plasma

Commits

Summary

The negative top margin was not necessary and causes missing round corners.

Test Plan

No visual change on master
With D29479, rounded corners should appear again

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

niccolove requested review of this revision.May 6 2020, 6:02 PM

niccolove added a reviewer: Plasma.

niccolove edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.May 6 2020, 6:15 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/notifications/package/contents/ui/NotificationItem.qml (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82129	7e4b097		May 6 2020, 6:02 PM	★	★
Diff 2	82145	7e4b097	R120:571f0aba2fc5238d48dbe09803e2c2b6b57c5f56	May 6 2020, 7:36 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4258e51eec8f	70b023b0fdf2	7e4b0979bbbb	Niccolò Venerandi	This removes the negative top margin, as it's already removed by the… (Show More…)	May 6 2020, 6:02 PM