Add inHistory bool and hide heading on inHistory
ClosedPublic
Actions

Authored by niccolove on May 6 2020, 8:48 AM.

Details

Reviewers

broulik
ngraham

Maniphest Tasks

T10470: Improve the visuals of tray popups

Commits

Summary

This hides the plasmoidHeading on history for not grouped notifications

Test Plan

After:

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

niccolove requested review of this revision.May 6 2020, 8:48 AM

niccolove added a reviewer: broulik.

Make sure @broulik agrees though

This revision is now accepted and ready to land.May 6 2020, 2:07 PM

I kinda think this should be named more generically, e.g. headerBackgroundVisible

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/notifications/package/contents/ui/FullRepresentation.qml (1 line)
M			applets/notifications/package/contents/ui/NotificationItem.qml (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82066	bf6b835		May 6 2020, 8:48 AM	★	★
Diff 2	82128	54f59eb	R120:7e4b0979bbbb42f5ed6e9e9794669a5222df02e4	May 6 2020, 6:01 PM	★	★