[kcmkwin/kwindecoration] Don't exec() QDialog
ClosedPublic

Authored by broulik on May 6 2020, 8:22 AM.

Details

Summary

Using nested event loops with QML is always troublesome.

BUG: 421053
FIXED-IN: 5.18.6

Test Plan
  • Can edit plastik settings without it crashing, saving settings applies immediately
  • Can edit breeze settings still, saving settings applies immediately

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.May 6 2020, 8:22 AM
Restricted Application added a project: KWin. · View Herald TranscriptMay 6 2020, 8:22 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.May 6 2020, 8:22 AM
zzag added a subscriber: zzag.May 6 2020, 8:35 AM
zzag added inline comments.
kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp
33–41

Why are QQuick includes separated?

237

Have we come to the conclusion whether we should use QQuickRenderControl::renderWindowFor in KCMs? If so, could you please point me to the discussion?

broulik added inline comments.May 6 2020, 8:47 AM
kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp
237

I recall it being needed for:

  • External apps
  • On wayland

I don't remember where a discussion took place.

broulik updated this revision to Diff 82067.May 6 2020, 8:48 AM
  • Fix include order
zzag accepted this revision.May 6 2020, 1:08 PM
This revision is now accepted and ready to land.May 6 2020, 1:08 PM
This revision was automatically updated to reflect the committed changes.