Differential D29458

scripting: Make workspace.currentActivity writable
ClosedPublic
Actions

Authored by tcorreabr on May 5 2020, 8:47 PM.

Details

Reviewers
None
Group Reviewers
KWin
Commits
R108:e38a241048ed: scripting: Make workspace.currentActivity writable
Summary

Allows KWin scripts to change the value of workspace.currentActivity property.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcorreabr created this revision.May 5 2020, 8:47 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 5 2020, 8:47 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
tcorreabr requested review of this revision.May 5 2020, 8:47 PM
zzag added a subscriber: zzag.May 6 2020, 6:54 AM
zzag added inline comments.
scripting/workspace_wrapper.cpp
123

Could you please remove the semicolon. The Q_UNUSED macro is defined as #define Q_UNUSED(x) (void)x; so you don't need to put semicolon and I think Qt Creator will print a warning.

zzag added a comment.May 6 2020, 7:19 AM

git nitpick: please use imperative mood in the subject line, e.g. scripting: Make workspace.currentActivity writable

tcorreabr updated this revision to Diff 82154.May 6 2020, 8:11 PM

Q_UNUSED semicolon removed.

tcorreabr marked an inline comment as done.May 6 2020, 8:11 PM
tcorreabr retitled this revision from workspace.currentActivity write access to scripting: Make workspace.currentActivity writable.May 6 2020, 9:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 5:37 AM
Closed by commit R108:e38a241048ed: scripting: Make workspace.currentActivity writable (authored by tcorreabr, committed by zzag). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82171

View Options

scripting/workspace_wrapper.h

Loading...
View Options

scripting/workspace_wrapper.cpp

Loading...