| bugseforuns | |
| ngraham |
| KNewStuff | |
| Plasma | |
| Frameworks |
This patch primarily fixes the issue that when picking the "Updateable Only" option on NewStuff.Page, we would be shown all the entries anyway. It also fixes duplicated entries on the "Installed Only" option, and further adds a little placeholder for when the view is expectedly empty.
BUG:416762
Without this patch, behaviour is as shown in https://bugs.kde.org/show_bug.cgi?id=416762
With this patch, the behaviour is as expected (shows only updateable entries with that option selected, only shows installed entries once with that option, and shows a useful message when the list is empty and expected to be empty)
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/core/itemsmodel.cpp | ||
|---|---|---|
| 71 | Use qAsConst(m_entries) and space before & not after :-) | |
| src/core/itemsmodel.cpp | ||
|---|---|---|
| 71 | On second thought why not just use: | |
As @alex suggests, just use qlist::contains, it is supposed to be
reasonably cheap, so... yup, trust the framework! ;)