[TabBox] Switch between windows with mouse wheel
AbandonedPublic

Authored by broulik on Oct 5 2016, 11:10 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma: Design
Plasma
Test Plan

Pressed Alt+Tab and held Alt, mousewheeled over tabbox, it switched windows.

It does not wrap around when I reach the beginnign or end - should it?

It doesn't scroll the list like a regular scrollbar would but switches to the next/previous window on each wheel tick (which I think is what the user would expect), scrolling when the window would be out of view.

Bug 369661 is about the compact switcher, not the default one. So perhaps kwin itself needs to have some magic for that? Dunno. Still neat feature to have in the default layout I guess.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 7113.Oct 5 2016, 11:10 AM
broulik retitled this revision from to [TabBox] Switch between windows with mouse wheel.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 5 2016, 11:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this object.Oct 5 2016, 12:13 PM
broulik edited the test plan for this revision. (Show Details)

Behavior sounds sensible, wrapping around would make sense, though.

broulik updated this revision to Diff 7114.Oct 5 2016, 1:05 PM

Let mouse wheel wrap around

graesslin requested changes to this revision.Oct 5 2016, 1:05 PM
graesslin added a reviewer: graesslin.
graesslin added a subscriber: graesslin.

KWin internally already handles mouse wheel. See kwin/tabbox/tabbox.cpp method Tabbox::handleMouseEvent

This revision now requires changes to proceed.Oct 5 2016, 1:05 PM

Also I just tried on Wayland (as I'm on Wayland right now) and there mouse wheel works correctly. So no change needed.

broulik abandoned this revision.Oct 5 2016, 2:50 PM

Some Kwin/Qt event handling issue, wheeling outside the tabbox window actually works.