diff --git a/kcmkwin/kwinrules/CMakeLists.txt b/kcmkwin/kwinrules/CMakeLists.txt --- a/kcmkwin/kwinrules/CMakeLists.txt +++ b/kcmkwin/kwinrules/CMakeLists.txt @@ -53,4 +53,4 @@ install(TARGETS kcm_kwinrules DESTINATION ${PLUGIN_INSTALL_DIR}/kcms) install(FILES kcm_kwinrules.desktop DESTINATION ${SERVICES_INSTALL_DIR}) -kpackage_install_package(package kcm_kwinrules kcms) +kpackage_install_package(package kcmkwinrules kcms) diff --git a/kcmkwin/kwinrules/Messages.sh b/kcmkwin/kwinrules/Messages.sh --- a/kcmkwin/kwinrules/Messages.sh +++ b/kcmkwin/kwinrules/Messages.sh @@ -1,4 +1,2 @@ #! /usr/bin/env bash -$EXTRACTRC *.ui >> rc.cpp || exit 11 -$XGETTEXT *.cpp *.h -o $podir/kcmkwinrules.pot -rm -f rc.cpp +$XGETTEXT `find . -name \*.cpp -o -name \*.h -o -name \*.qml` -o $podir/kcmkwinrules.pot diff --git a/kcmkwin/kwinrules/kcmrules.cpp b/kcmkwin/kwinrules/kcmrules.cpp --- a/kcmkwin/kwinrules/kcmrules.cpp +++ b/kcmkwin/kwinrules/kcmrules.cpp @@ -38,7 +38,7 @@ , m_ruleBookModel(new RuleBookModel(this)) , m_rulesModel(new RulesModel(this)) { - auto about = new KAboutData(QStringLiteral("kcm_kwinrules"), + auto about = new KAboutData(QStringLiteral("kcmkwinrules"), i18n("Window Rules"), QStringLiteral("1.0"), QString(), diff --git a/kcmkwin/kwinrules/package/contents/ui/RulesList.qml b/kcmkwin/kwinrules/package/contents/ui/RulesList.qml --- a/kcmkwin/kwinrules/package/contents/ui/RulesList.qml +++ b/kcmkwin/kwinrules/package/contents/ui/RulesList.qml @@ -79,24 +79,11 @@ showCloseButton: true text: i18n("Select the rules to export") actions: [ - Kirigami.Action { - iconName: "object-select-symbolic" - text: checked ? i18n("Unselect All") : i18n("Select All") - checkable: true - checked: selectedIndexes.length == ruleBookView.count - onToggled: { - if (checked) { - selectedIndexes = [...Array(ruleBookView.count).keys()] - } else { - selectedIndexes = []; - } - } - } - , Kirigami.Action { iconName: "document-save" text: i18n("Save Rules") - enabled: selectedIndexes.length > 0 + // FIXME: It does not update on selection changes + // enabled: selectedIndexes.length > 0 onTriggered: { exportDialog.active = true; } @@ -125,8 +112,8 @@ } } QQC2.Button { - text: checked ? i18n("Cancel Export") : i18n("Export...") - icon.name: exportInfo.visible ? "dialog-cancel" : "document-export" + text: i18n("Export...") + icon.name: "document-export" enabled: ruleBookView.count > 0 checkable: true checked: exportInfo.visible @@ -226,7 +213,6 @@ } else { if (position >= 0) { selectedIndexes.splice(position, 1); } } - selectedIndexesChanged(); } } }