Add an option to force alphabetic sorting to Kicker/Kickoff.
ClosedPublic

Authored by hein on Oct 4 2016, 8:59 PM.

Details

Summary

And default to on.

I don't like this, but downstream complains that their users get
confused when using kmenuedit to edit their menu and newly-
installed apps are no longer sorted-in alphabetically in the
presence of the kmenuedit-generated files causing sorting to be
disabled. And we don't have the resources to fix kmenuedit.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein updated this revision to Diff 7102.Oct 4 2016, 8:59 PM
hein retitled this revision from to Add an option to force alphabetic sorting to Kicker/Kickoff..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added a reviewer: mart.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 4 2016, 8:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

And we don't have the resources to fix kmenuedit.

Can you expand on what's wrong?

hein added a comment.Oct 4 2016, 10:23 PM

Can you expand on what's wrong?

No, I don't know what's wrong exactly or if anything is even wrong.

Apparently using kmenuedit to edit and/or reorder apps writes out a file, and this then stops the otherwise alphabetical sorting, so newly installed apps aren't sorted in alphabetically.

This makes sense to me to some degree, because obviously you can't "sort in things alphabetically" when the list isn't alphabetical to begin with, but I guess editing that doesn't change order or names maybe shouldn't stop sorting.

Downstream is convinced this is all confusing to users even if they do it to themselves and asked for an alphabetic sorting option.

note: it was overall discussed and agreed that this optional sort is providing a solution in certain cases without changing anything when not making it "default on", which was never requested to do.

davidedmundson accepted this revision.Oct 6 2016, 2:32 AM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
applets/kicker/plugin/appsmodel.cpp
306

at some point you should look into adding a QQmlParserStatus in here, I'm sure you'll end up refreshing() multiple times on boot.

This revision is now accepted and ready to land.Oct 6 2016, 2:32 AM
hein added a comment.Oct 6 2016, 2:35 AM

^ True, I was thinking about that while writing it, too @ QQmlParserStatus.

This revision was automatically updated to reflect the committed changes.