This is a replacement for CloseOnWidgetActivated that operates on a QWindow instead of QWidget.
Details
Details
Diff Detail
Diff Detail
- Repository
- R289 KNotifications
- Branch
- closewin
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 27019 Build 27037: arc lint + arc unit
Comment Actions
Generally +1
The QWidget one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful?
Not a fan of the timer.
Also, we might want to deprecate the QWidget one now?
Comment Actions
I'll take a look
Not a fan of the timer.
Me neither, but the widgets code has this too, so I kept it. I can remove it though if we decide we don't want it
Also, we might want to deprecate the QWidget one now?
That's my plan, but I still need to port some things
| src/knotification.h | ||
|---|---|---|
| 598 | And some remarks from a local API docs pedant :) Please place the text not on the first line after "/**", but the second line only (for consistency at least). Also keep indent at one space in the following lines then again afte the asterisk. Also wants a "@since" note, same with the getter :) Them being jealous on the one you gave to the flag. I would also propose to place these methods for the new property before the two methods tagged with "@internal", to keep some ordering in the list of methods for the human reader of the code. | |
Comment Actions
lol, turns out that doesn't even work when using setWidget instead of the ctor with a widget because of 30b10492
| src/knotification.h | ||
|---|---|---|
| 253 | Should we deprecate this? Or just use this one instead. I don't see why we would have separate enum values for those | |