Differential D29380

[System Tray] Always draw the highlight behind the icon
ClosedPublic
Actions

Authored by filipf on May 3 2020, 10:12 AM.

Details

Reviewers
kmaterka
Group Reviewers
Plasma
Commits
R120:3f06349549c1: [System Tray] Always draw the highlight behind the icon
Summary

There was a slight issue introduced with D28109: the systray highlight can now cover up the icons it's highlighting.

This isn't really an issue with Breeze because it uses a line for a highlight, but it is for themes that use a filled-style highlight.

I set a z value for the highlight that should ensure it's now drawn only behind the icon.

Test Plan

Tested with the Mondrian Plasma theme

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
draw-behind-icons (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26260
Build 26278: arc lint + arc unit
filipf created this revision.May 3 2020, 10:12 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 3 2020, 10:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.May 3 2020, 10:12 AM
filipf edited the test plan for this revision. (Show Details)May 3 2020, 10:14 AM
filipf added reviewers: kmaterka, Plasma.
kmaterka requested changes to this revision.May 3 2020, 10:49 AM

The same treatment is needed in HiddenItemsView to. Just move z: -1 to CurrentItemHighLight component so that your fix will cover both cases.

This revision now requires changes to proceed.May 3 2020, 10:49 AM
filipf updated this revision to Diff 81796.May 3 2020, 12:59 PM

move the code change to CurrentItemHighlight.qml

kmaterka accepted this revision.May 3 2020, 1:26 PM

OK, accepted

This revision is now accepted and ready to land.May 3 2020, 1:26 PM
Closed by commit R120:3f06349549c1: [System Tray] Always draw the highlight behind the icon (authored by filipf). · Explain WhyMay 3 2020, 4:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81785

View Options

applets/systemtray/package/contents/ui/main.qml

Loading...