always connect to "Local" source
ClosedPublic

Authored by mart on Oct 4 2016, 3:22 PM.

Details

Summary

We need Local to be *always* present, even if not disaplayed as
it's used for formatting in ToolTip.dateTimeChanged()
this makes sure local is always in the connected sources, even if
it's not explicitly shown to the user

Test Plan

tested, local timezone is not shown in clock/tooltip when
selected, and no warnings from dateTimeChanged()

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 7095.Oct 4 2016, 3:22 PM
mart retitled this revision from to always connect to "Local" source.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 4 2016, 3:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Oct 4 2016, 4:27 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Oct 4 2016, 4:27 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Oct 5 2016, 8:59 AM
broulik added inline comments.
applets/digital-clock/package/contents/ui/main.qml
77

Can't you just bind that without Connections? (or as a readonly property var like above if you find that cleaner)

connectedSources: {
    var ts = plasmoid.configuration.selectedTimeZones;
    if (ts.indexOf("Local") === -1) {
        ts.push("Local")
    }
    return ts
}