[applets/systemtray] Fix value read in some onXyxChanged connections
ClosedPublic
Actions

Authored by kmaterka on May 2 2020, 9:08 AM.

Details

Reviewers

Group Reviewers

Plasma: Workspaces
Plasma

Commits

Summary

Some onXyzChanged signals do not send value - fix connection to use value directly from the sender.

Test Plan

Disable or enable plasmoid in System Tray setting - it should work correctly.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

kmaterka requested review of this revision.May 2 2020, 9:08 AM

Fix exctracted from D29344, to make things clear - one commit, one change.

applets/systemtray/package/contents/ui/main.qml
81–82	`Plasma::Applet::userConfiguringChanged` sends value, but `Plasma::AppletInterface::userConfiguringChanged` does not (signal has no parameters).
91–92	I'm pretty sure this worked before... Maybe something changed in `QQmlPropertyMap` in Qt 5.14?

apol accepted this revision.May 3 2020, 2:48 PM

This revision is now accepted and ready to land.May 3 2020, 2:48 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/systemtray/package/contents/ui/main.qml (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	81726	3a8c740		May 2 2020, 9:08 AM	★	★
Diff 2	81804	3a8c740	R120:efe4b603e92f0ab95ae8a86978fcd003dada4a8f	May 3 2020, 2:52 PM	★	★