Differential D29356

[applets/systemtray] Fix value read in some onXyxChanged connections
ClosedPublic
Actions

Authored by kmaterka on May 2 2020, 9:08 AM.

Details

Reviewers
ngraham
apol
broulik
davidedmundson
Group Reviewers
Plasma: Workspaces
Plasma
Commits
R120:efe4b603e92f: [applets/systemtray] Fix value read in some onXyxChanged connections
Summary

Some onXyzChanged signals do not send value - fix connection to use value directly from the sender.

Test Plan

Disable or enable plasmoid in System Tray setting - it should work correctly.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26221
Build 26239: arc lint + arc unit
kmaterka created this revision.May 2 2020, 9:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 2 2020, 9:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kmaterka requested review of this revision.May 2 2020, 9:08 AM
kmaterka added a comment.May 2 2020, 9:16 AM

Fix exctracted from D29344, to make things clear - one commit, one change.

applets/systemtray/package/contents/ui/main.qml
81

Plasma::Applet::userConfiguringChanged sends value, but Plasma::AppletInterface::userConfiguringChanged does not (signal has no parameters).

91

I'm pretty sure this worked before... Maybe something changed in QQmlPropertyMap in Qt 5.14?

apol accepted this revision.May 3 2020, 2:48 PM
This revision is now accepted and ready to land.May 3 2020, 2:48 PM
Closed by commit R120:efe4b603e92f: [applets/systemtray] Fix value read in some onXyxChanged connections (authored by kmaterka). · Explain WhyMay 3 2020, 2:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81726

View Options

applets/systemtray/package/contents/ui/main.qml

Loading...