[sddm-theme] Prevent the logo from leaking in after a fadeout
ClosedPublic

Authored by filipf on May 1 2020, 8:29 PM.

Details

Summary

Even when the vendor logo is turned off it can be briefly seen when the login screen changes from the fadeout state back into normal.

Comments in other code say that "OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)" so this patch replaces it with NumberAnimation.

There's also a minor fix included - placing the drop shadow sooner in the hierarchy because it should be drawn underneath an object, not in front of it.

Test Plan

Reduce the fadeout time to something small and then:

sddm-greeter --test-mode --theme /usr/share/sddm/themes/breeze

Diff Detail

Repository
R120 Plasma Workspace
Branch
no-logo-leak (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26210
Build 26228: arc lint + arc unit
filipf created this revision.May 1 2020, 8:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 1 2020, 8:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.May 1 2020, 8:29 PM
filipf edited the test plan for this revision. (Show Details)May 1 2020, 8:30 PM
filipf added reviewers: ngraham, cblack, Plasma.
filipf added a comment.May 1 2020, 8:43 PM

This kills the animation though... I found this comment in other code:
"//OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)"

I'm able to get this opacity fading effect though without the bug if I switch from using OpacityAnimator to PropertyAnimator.

filipf updated this revision to Diff 81709.May 1 2020, 8:48 PM

Ditch OpacityAnimator and use PropertyAnimation

filipf edited the summary of this revision. (Show Details)May 1 2020, 8:49 PM
mart requested changes to this revision.May 4 2020, 9:23 AM
mart added a subscriber: mart.

unfortunately yeah, i had to port away from opacityanimator several places for this reason :(

sddm-theme/Main.qml
449

please use NumberAnimation
(it's the same as propertyaniation but goes trough a qvariant conversion less, so i preferrable for animate properties of type int or real)

This revision now requires changes to proceed.May 4 2020, 9:23 AM
filipf updated this revision to Diff 81910.May 4 2020, 3:37 PM
filipf marked an inline comment as done.

Replace PropertyAnimation with NumberAnimation

ngraham accepted this revision.May 4 2020, 4:28 PM
filipf edited the summary of this revision. (Show Details)May 4 2020, 11:22 PM

Should I also land this for 5.18 (do I have to create a bug report first)?

Wait for @mart, but landing on the stable branch seems safe. No need for a bug report if there isn't already one open.

Is this okay now @mart and okay to land on 5.18?

mart accepted this revision.May 12 2020, 4:47 PM
This revision is now accepted and ready to land.May 12 2020, 4:47 PM
This revision was automatically updated to reflect the committed changes.