Differential D29341

[kcm/kwinrules] Improve export buttons
ClosedPublic
Actions

Authored by iasensio on May 1 2020, 3:53 PM.

Details

Reviewers
filipf
Group Reviewers
KWin
VDG
Commits
R108:1a3cb256d741: [kcm/kwinrules] Improve export buttons
Summary

Small UX improvements when exporting rules

Add a Select All button
Disable Save if no rules are selected
In export mode set button text to Cancel Export

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.May 1 2020, 3:53 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 1 2020, 3:53 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
iasensio requested review of this revision.May 1 2020, 3:53 PM
filipf accepted this revision.May 1 2020, 7:47 PM
filipf added a subscriber: filipf.

Looks good and improves usability.

This revision is now accepted and ready to land.May 1 2020, 7:47 PM
Closed by commit R108:1a3cb256d741: [kcm/kwinrules] Improve export buttons (authored by iasensio). · Explain WhyMay 2 2020, 5:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81749

View Options

kcmkwin/kwinrules/package/contents/ui/RulesList.qml

Loading...