| nicolasfella |
This is available starting at API level 20, which is below our minimal
requirement. Grouping can be disabled by the already existing SkipGrouping
flag.
When enabled this puts all notifications from the same eventId in a group,
which makes the display more compact by removing the otherwise duplicated
app name.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Haven't tested it, but the code looks sensible
| src/android/org/kde/knotifications/NotifyByAndroid.java | ||
|---|---|---|
| 258 | Please use https://developer.android.com/reference/android/os/Build.VERSION_CODES instead of hardcoding numbers | |
| src/android/org/kde/knotifications/NotifyByAndroid.java | ||
|---|---|---|
| 258 | That seems counter-productive to me, as the Android API documentation always speaks about API level numbers, so you'd need to do an additional translation to/from the letters in your head. So for that I find "26" more useful here than "O". It's also consistent with the rest of the code in this file. | |
| src/android/org/kde/knotifications/NotifyByAndroid.java | ||
|---|---|---|
| 258 | You have a point | |
This isn't good to go yet, there are corner cases where the group summary item stays around after closing the last notification, working on fixing this.
Explicitly track if notification groups are still in use.
This fixes group summaries staying active when we explicitly
close a notification, rather then having the user or system
dismiss it.
Still not good enough, updating existing notfication messes up the refcounter, resulting still in leftover group elements.
Replace the simple ref count with a full child id tracking.
The ref count got out of sync when an existing notification is updated, using a set fixes that.
