Add DataControl iface
AbandonedPublic
Actions

Authored by davidedmundson on May 1 2020, 1:22 PM.

Details

Reviewers

None

Group Reviewers

KWin

Summary

This patch makes use of wlroot's DataControl interface to support
clipboard management.

Unlike wl_data_device clipboards are sent on every change to all watchers.
If the data device has a selection set it updates immediately.

Because it was started a year ago it uses the existing style of
wrapping objects. The unit test uses the new approach.

Test Plan

Updated kwin
used wlroot's wl-copy, wl-paste which are xclip replacements to
show that the clipboard updated correctly

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 26458
Build 26476: arc lint + arc unit

davidedmundson requested review of this revision.May 1 2020, 1:22 PM

davidedmundson created this revision.

fix includes to kwaylandserver

handle a data control changing selection when inactive better

		Path
M		autotests/server/CMakeLists.txt (12 lines)
A	M	autotests/server/test_datacontrol_interface.cpp (274 lines)
A	M	src/protocols/README.md (1 line)
A	M	src/protocols/wlr-data-control-unstable-v1.xml (278 lines)
M		src/server/CMakeLists.txt (13 lines)
A	M	src/server/datacontroldevice_interface.h (75 lines)
A	M	src/server/datacontroldevice_interface.cpp (181 lines)
A	M	src/server/datacontroldevicemanager_interface.h (59 lines)
A	M	src/server/datacontroldevicemanager_interface.cpp (133 lines)
A	M	src/server/datacontroloffer_interface.h (62 lines)
A	M	src/server/datacontroloffer_interface.cpp (102 lines)
A	M	src/server/datacontroloffer_interface_p.h (51 lines)
A	M	src/server/datacontrolsource_interface.h (61 lines)
A	M	src/server/datacontrolsource_interface.cpp (125 lines)
M		src/server/display.h (7 lines)
M		src/server/display.cpp (11 lines)
M		src/server/seat_interface.h (1 line)
M		src/server/seat_interface.cpp (40 lines)
M		src/server/seat_interface_p.h (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	81670	1acfc7a		May 1 2020, 1:22 PM	★	★
Diff 2	81886	8034ef6	fix includes to kwaylandserver	May 4 2020, 1:56 PM	★	★
Diff 3	82120	8034ef6	handle a data control changing selection when inactive better	May 6 2020, 4:20 PM	★	★