KCM Plasmasearch: Do not intialize runners in config module
ClosedPublic

Authored by alex on May 1 2020, 6:37 AM.

Details

Summary

The runners are loaded from the plugin info list Plasma::RunnerManager::listRunnerInfo(),
because of that there is no need to create a RunnerManager and initialize the plugins.

If you have a lot of additional plugins installed that do a lot of work in the init/reloadConfiguration
method the loading time of the KCM is notable slower.

Additionally the KCMUTILS_VERSION version check has been removed, because
the KF5_MIN_VERSION is 5.69.

Test Plan

All plugin should show up.
To check this create a debug which prints the length of the listRunnerInfo list.
Then you can verify that the length of the list is equal to the count
of entries in the plugin selector. For this you can also use the xdotool utility:
sleep 5;for i in {1..myNum}; do sleep 0.1;xdotool key Down; done.

Diff Detail

Repository
R119 Plasma Desktop
Branch
do_not_initialize_runners (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26169
Build 26187: arc lint + arc unit
alex created this revision.May 1 2020, 6:37 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 1 2020, 6:37 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alex requested review of this revision.May 1 2020, 6:37 AM
ngraham accepted this revision.May 1 2020, 3:07 PM
This revision is now accepted and ready to land.May 1 2020, 3:07 PM
alex updated this revision to Diff 81692.May 1 2020, 3:20 PM

Change username from commit

And thanks for the fast reviews!

This revision was automatically updated to reflect the committed changes.