Differential D29313

Port VehicleLayoutPage to Scrollablepage
ClosedPublic
Actions

Authored by nicolasfella on Apr 30 2020, 6:51 PM.

Details

Reviewers
vkrause
Commits
R1032:3deae065e401: Port VehicleLayoutPage to Scrollablepage
Summary

Put the content into a ScrollablePage so we don't need to mess with Flickables ourselves. This simplifies the code and improves the scrollbar and scrolling behaviour.

I plan to "borrow" the code for KTrip.

Test Plan

Before:

After:

Diff Detail

Repository
R1032 KPublicTransport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Apr 30 2020, 6:51 PM
nicolasfella created this revision.
nicolasfella updated this revision to Diff 81622.Apr 30 2020, 6:52 PM
  • Fix accidental change
nicolasfella edited the test plan for this revision. (Show Details)Apr 30 2020, 6:54 PM
vkrause accepted this revision.Apr 30 2020, 7:15 PM

Don't remember why I ended up doing it like this back then...

This revision is now accepted and ready to land.Apr 30 2020, 7:15 PM
Closed by commit R1032:3deae065e401: Port VehicleLayoutPage to Scrollablepage (authored by nicolasfella). · Explain WhyApr 30 2020, 7:16 PM
This revision was automatically updated to reflect the committed changes.
vkrause added a comment.Apr 30 2020, 7:16 PM

Oh, regarding borrowing for KTrip, you might want to check the one in Itinerary, that does some better train length scaling IIRC.

Revision Contents
Changeset List

PathPackages
Mtests/VehicleLayoutPage.qml (225 lines)

Diff 81624

View Options

tests/VehicleLayoutPage.qml

Loading...