Differential D29311

Emit low battery notification immediately when plugging out AC
Changes PlannedPublic
Actions

Authored by broulik on Apr 30 2020, 6:03 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

When plugging out AC, emit a low battery notification immediately, so one is notified of the fact that AC was unplugged with low battery.

Test Plan
  • Unplugged AC, got notification right away tha tbattery was low
  • Unplugged AC with enoguh percentage, did not get a notification

Diff Detail

Repository
R122 Powerdevil
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 30 2020, 6:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 30 2020, 6:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 30 2020, 6:03 PM
ngraham added a subscriber: ngraham.Apr 30 2020, 6:25 PM

Hmm, this isn't working for me, or else I'm not testing it correctly.

I set the "low battery threshold" to 99% while my battery is only 93% charged and, unplug my cord. I should see a notification, right? But I don't.

broulik added a comment.Apr 30 2020, 6:26 PM

Do you get the sound that you unplugged? For me it sometimes took quite a while for it to actually recognize I unplugged

ngraham added a comment.Apr 30 2020, 6:31 PM

Yep I get the sound, and the display brightness falls immediately. It's just thew low battery notification that doesn't appear immediately.

(nice catch, BTW)

broulik planned changes to this revision.Apr 30 2020, 6:32 PM

Hmm, odd, will have to do further testing then

Revision Contents
Changeset List

PathPackages
Mdaemon/powerdevilcore.cpp (2 lines)

Diff 81617

View Options

daemon/powerdevilcore.cpp

Loading...