Differential D29303

Make KI18N_INSTALL() compatible to KDE_INSTALL_DIRS_NO_DEPRECATED
Needs ReviewPublic
Actions

Authored by kossebau on Apr 30 2020, 4:27 PM.

Details

Reviewers
ilic
heikobecker
Summary

LOCALE_INSTALL_DIR is a deprecated variable from KDEInstallDirs,
which will not be set with KDE_INSTALL_DIRS_NO_DEPRECATED

Diff Detail

Repository
R249 KI18n
Branch
fixki18ninstallundeprecated
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26143
Build 26161: arc lint + arc unit
kossebau created this revision.Apr 30 2020, 4:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 30 2020, 4:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 30 2020, 4:27 PM
dfaure added a subscriber: dfaure.Dec 26 2020, 10:50 AM

So this is basically the same as https://phabricator.kde.org/D29136 except that D29136 gives priority to the non-deprecated variable. Any reason against going with D29136 after all?

heikobecker added a comment.Jan 2 2021, 10:31 PM
In D29303#677015, @dfaure wrote:

So this is basically the same as https://phabricator.kde.org/D29136 except that D29136 gives priority to the non-deprecated variable. Any reason against going with D29136 after all?

Not from me.

Revision Contents
Changeset List

PathPackages
Mcmake/KF5I18nMacros.cmake.in (37 lines)

Diff 81599

View Options

cmake/KF5I18nMacros.cmake.in

Loading...