Currently PagePoolAction only supports pushing to a pageStack, but often it makes sense to use layers to push modal/contextual pages (outside of the primary pageStack flow). This change introduces support for a "useLayers" property that can be set on PagePoolAction, allowing it use the pageStack.layers StackView (if it exists). It also includes a unit test and a couple fixes uncovered by the test.
Details
Details
- Reviewers
mart - Group Reviewers
Kirigami - Commits
- R169:9c3c2d1a2379: Add support for layers to PagePoolAction.
See the tst_layers unit test included.
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- add-pagepool-layer-support (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26119 Build 26137: arc lint + arc unit
| src/controls/PagePoolAction.qml | ||
|---|---|---|
| 159 | Actually I realized why I did this now: the Action type does not allow assignment to default property so it is required to create a property here. I will put a comment on this but I need to add that back into the code, unless there is another pattern for this. If I were to create another "default" property, it would still be exposed to the public. It will likely have to be one of those things people just don't touch unless they want to break something. | |