Port KWin to KWaylandServer
ClosedPublic

Authored by apol on Apr 29 2020, 3:19 PM.

Details

Summary

Away from KWayland::Server and KF5WaylandServer.

Test Plan

Builds, ran nested session

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 29 2020, 3:19 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 29 2020, 3:19 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
apol requested review of this revision.Apr 29 2020, 3:19 PM
zzag added a subscriber: zzag.Apr 30 2020, 6:17 AM

Hmm, I can't build kwin

/home/vlad/Workspace/KDE/src/kde/workspace/kwin/libkwineffects/kwineffects.cpp:44:10: fatal error: KWaylandServer/surface_interface.h: No such file or directory
   44 | #include <KWaylandServer/surface_interface.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
CMakeLists.txt
131

Well, we need it to make the wayland session work.

646

I feel like it should be KWaylandServer::KWaylandServer but we can revisit it.

libkwineffects/kwineffects.h
68–70

This breaks source compatibility, but I guess we don't have a choice.

davidedmundson accepted this revision.Apr 30 2020, 10:10 AM
This revision is now accepted and ready to land.Apr 30 2020, 10:10 AM

Hmm, I can't build kwin

Hit the same thing, we've since fixed that (patch in kwayland-server)

apol marked an inline comment as done.Apr 30 2020, 10:48 AM
apol updated this revision to Diff 81574.Apr 30 2020, 10:48 AM

Address @zzag's comments

zzag accepted this revision.Apr 30 2020, 10:49 AM
This revision was automatically updated to reflect the committed changes.