| davidedmundson |
| KWin |
cca0e15b455ba6 broke code that calculates the value of the fps counter.
The frames field stores timestamps of previous frames, not time between
each two consecutive frames.
This change doesn't attempt to make the show fps compute more accurate
performance metrics, e.g. how much times it takes to execute rendering
commands on the GPU, etc.
The Show FPS effect displays more sensible values.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| effects/showfps/showfps.cpp | ||
|---|---|---|
| 126 | Can you not store the current time of the timer rather than going through QDateTime? | |
| effects/showfps/showfps.cpp | ||
|---|---|---|
| 126 | Uh, do you suggest to use an alternative approach for counting fps? | |
Just to be clear... The Show FPS effect assigns a timestamp to every frame and then counts how many frames were painted within the last second. This patch only intends to fix a regression and not change the frame counting algorithm. Let's discuss whether the frame counting algorithm is good somewhere else, e.g. a Phabricator task or kwin mailing list.
It certainly is weird to use a combo of QElapsedTimer and timestamps, but sure, lets discuss that another day