WIP: redesign sidebar
Needs ReviewPublic

Authored by ognarb on Apr 27 2020, 10:23 PM.

Details

Reviewers
boemann

Diff Detail

Repository
R8 Calligra
Branch
redesign
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26011
Build 26029: arc lint + arc unit
ognarb created this revision.Apr 27 2020, 10:23 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptApr 27 2020, 10:23 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
ognarb requested review of this revision.Apr 27 2020, 10:23 PM

My immidiate reaction is no.

Do you mind sharing a screenshot / drawing of what the end goal is here ?

There is a mockup here: T12837 this is really WIP I just created the diff because I asked someone to help me with a part of the code and I needed to show them the code.

Well you are definitely in the right class to make such changes.

The thing is the current code was made to adopt to many different user wishes - so the user could choose

What you are doing is to throw all that away - would it be impossible to have this new way as a mode so we don't throw away the old but enhance it with something new.

I don't mind if the new mode becomes default

I don't know why everyone wants tools to be above edit window. That's pretty old style when resolution ratio was 4:3 that's why they was arranged one above another. But i agree that it should be flexible to be horizontal or vertical as needed.

libs/widgets/KoModeBox.cpp
485–494

Do not made unrelated changes.

ognarb planned changes to this revision.Apr 28 2020, 11:23 AM

Well you are definitely in the right class to make such changes.

The thing is the current code was made to adopt to many different user wishes - so the user could choose

What you are doing is to throw all that away - would it be impossible to have this new way as a mode so we don't throw away the old but enhance it with something new.

I don't mind if the new mode becomes default

The idea is to remove some of the configuration possibility: for example only allowing the KoModeBoxDocker to be a left or right sidebar. (putting at the top and bottom was completely broken anyway so I don't think many people did it).

For the TabBar orientation, I'm trying to create only the the one in the first mockup from manueljlin and then add then probably the also the one from the last mockup. This is really WIP and I didn't thought it would be send to the mailing list :/

The idea is to remove some of the configuration possibility: for example only allowing the KoModeBoxDocker to be a left or right sidebar. (putting at the top and bottom was completely broken anyway so I don't think many people did it).

I think it can be repaired, it's broken, i agree.

ognarb updated this revision to Diff 81490.Apr 29 2020, 8:21 AM
  • More work in progress change

TODO

  • don't make KoModeBox public
  • Implement add shapes action
  • Figure out how to draw line seperator
  • Fix some issues found when applying the Breeze ToolArea patch
words/part/calligrawords.rc
2 ↗(On Diff #81490)

Increase version.

Well you are definitely in the right class to make such changes.

The thing is the current code was made to adopt to many different user wishes - so the user could choose

What you are doing is to throw all that away - would it be impossible to have this new way as a mode so we don't throw away the old but enhance it with something new.

I don't mind if the new mode becomes default

I agree it's important to keep the ability to adapt to many users wishes. I recently started to use Calligra as i really like the current interface compared to many modern apps that try to hide things beneath more clicks and making them less discoverable, not to mention rely to much on simple iconography that becomes impossible to quickly pick out or memorize.

Not saying there isn't room for improvements, and the third screen from manueljin in issue T12837 looks nice in some ways, for example. The important thing I want to request is to not remove the drop-down menus and stuff them in a hamburger menu and to not remove the ability to have text under or next to icons. Text makes it very clear waht each action do and not only makes the program extremely easy to learn, it also makes it quicker to find the correct option, even for seasoned users like me. For some user groups, such as some people with aphasia, having text-based drop-down menus and text next to icons can mean the difference between being able to use an application at all or not. Long story short, please preserve the classic desktop design as an option. :) Not all software needs to be able to run on super-small screens and less is not equal to more when it comes to software design. Show - don't hide! ;)