- Port from deprecated dark() and light()
- Port from deprecated DesktopIcon
- Use KIconLoader::StdSizes instead of harcoded sizes
- Use QString() for empty strings
- Minimal style changes around those
Details
Details
- Reviewers
niccolove ognarb - Commits
- R1050:137a157ff8cb: Address some compiler warnings
Basket still compiles and works
Less compiler warnings
Diff Detail
Diff Detail
- Repository
- R1050 BasKet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/htmlexporter.cpp | ||
---|---|---|
471–473 | While at it you could replace "" with QString(), to create an empty string. |
Comment Actions
You can also the signals to use the Qt5 syntax.
connect(m_action, SIGNAL(triggered()), this, SLOT(activatedShortcut())); // old connect(m_action, &QAction::triggered, this, &BasketScene::activatedShortcut); // new
And the docs about this: https://wiki.qt.io/New_Signal_Slot_Syntax