Differential D29237

Multiple deprecation fixes
AcceptedPublic
Actions

Authored by hellozee on Apr 27 2020, 6:15 PM.

Details

Reviewers
ognarb
niccolove
Summary

Don't worry, these all will be separate commits, but for now they are too small to create a revision for each of them, so bundled them together.

Test Plan

There should be no change in the program.

Diff Detail

Repository
R1050 BasKet
Lint
Lint Skipped
Unit
Unit Tests Skipped
hellozee requested review of this revision.Apr 27 2020, 6:15 PM
hellozee created this revision.
ognarb added a comment.Apr 27 2020, 10:50 PM

LGTM :) just remove the part in src/variouswidgets.cpp that is in conflict with D29240.

src/basketlistview.cpp
508

I trust you with horizontalAdvance vs boudingRect (https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width) :D

src/variouswidgets.cpp
224

this is also fixed in D29240 but D29240 also improve i18n and use global variables. So maybe revert this part of the patch.

ognarb accepted this revision.Apr 27 2020, 10:50 PM
This revision is now accepted and ready to land.Apr 27 2020, 10:50 PM
ognarb added a comment.Jun 25 2020, 6:28 PM

Ping. Did you merge it?

Revision Contents
Changeset List

PathPackages
Msrc/basketlistview.cpp (16 lines)
Msrc/crashhandler.cpp (2 lines)
Msrc/variouswidgets.cpp (13 lines)

Diff 81375

View Options

src/basketlistview.cpp

Loading...
View Options

src/crashhandler.cpp

Loading...
View Options

src/variouswidgets.cpp

Loading...