[ksmserver] Use CommandLauncherJob for restoring applications
ClosedPublic

Authored by broulik on Apr 27 2020, 12:25 PM.

Details

Summary

Rather than calling into KLauncher directly.
I think silently failing rather than using a modal potentially interrupting startup is acceptable here?

Test Plan

Compiles, session restore apps are still launched like before

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 27 2020, 12:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 27 2020, 12:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 27 2020, 12:25 PM
broulik edited the summary of this revision. (Show Details)
dfaure requested changes to this revision.Apr 27 2020, 9:26 PM
dfaure added a subscriber: dfaure.
dfaure added inline comments.
ksmserver/server.cpp
134

(pre-existing) argList = command; argList.removeFirst(); would be simpler and faster.

137

This return statement serves no purpose.

This revision now requires changes to proceed.Apr 27 2020, 9:26 PM
broulik updated this revision to Diff 81419.Apr 28 2020, 9:06 AM
  • Simplify
  • Remove pointless return
dfaure accepted this revision.Apr 28 2020, 7:42 PM
This revision is now accepted and ready to land.Apr 28 2020, 7:42 PM
This revision was automatically updated to reflect the committed changes.

Did you possibly forget to commit the changes to the header file?