Use svg for tag icons
ClosedPublic
Actions

Authored by ognarb on Apr 26 2020, 2:36 PM.

Details

Reviewers

Commits

R1050:66436fc19bbf: Use svg for tag icons

Test Plan

rm -rf ~/.cache/icon-cache.kcache
and delete old icons in ~/.local/kde/share/icons/hicolor/16x16/actions/tag_*.png (not the checkbox)

Diff Detail

Repository

R1050 BasKet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ognarb requested review of this revision.Apr 26 2020, 2:36 PM

ognarb created this revision.

Harbormaster completed remote builds in B25928: Diff 81247.Apr 26 2020, 2:36 PM

ognarb added a reviewer: niccolove.Apr 26 2020, 2:37 PM

manueljlin says it is ok to license the icons to LGPL-2.0-or-later so we can upstream it later if needed

Harbormaster completed remote builds in B25932: Diff 81251.Apr 26 2020, 2:52 PM

ognarb edited the test plan for this revision. (Show Details)Apr 26 2020, 2:54 PM

USE LGPL-2.1-or-later

Harbormaster completed remote builds in B25946: Diff 81271.Apr 26 2020, 6:13 PM

IlyaBizyaev added a subscriber: IlyaBizyaev.Apr 26 2020, 7:06 PM

IlyaBizyaev added inline comments.

tags/sc-actions-tag_progress_100.svgz.license
4	LLGPL?

I should not trust my regex skils anymore :D

Harbormaster completed remote builds in B25949: Diff 81277.Apr 26 2020, 7:32 PM

niccolove accepted this revision.Apr 26 2020, 8:06 PM

This revision is now accepted and ready to land.Apr 26 2020, 8:06 PM

Closed by commit R1050:66436fc19bbf: Use svg for tag icons (authored by ognarb). · Explain WhyApr 26 2020, 8:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
M			basket.qrc (26 lines)
M			src/tag.cpp (10 lines)
D	M	(bin)	tags/16-actions-tag_for_later.png
D	M	(bin)	tags/16-actions-tag_fun.png
D	M	(bin)	tags/16-actions-tag_important.png
D	M	(bin)	tags/16-actions-tag_preference_bad.png
D	M	(bin)	tags/16-actions-tag_preference_excellent.png
D	M	(bin)	tags/16-actions-tag_preference_good.png
D	M	(bin)	tags/16-actions-tag_priority_high.png
D	M	(bin)	tags/16-actions-tag_priority_low.png
D	M	(bin)	tags/16-actions-tag_priority_medium.png
D	M	(bin)	tags/16-actions-tag_progress_000.png
D	M	(bin)	tags/16-actions-tag_progress_025.png
D	M	(bin)	tags/16-actions-tag_progress_050.png
D	M	(bin)	tags/16-actions-tag_progress_075.png
D	M	(bin)	tags/16-actions-tag_progress_100.png
M			tags/CMakeLists.txt (28 lines)
A	M	(bin)	tags/sc-actions-tag_for_later.svgz
A	M		tags/sc-actions-tag_for_later.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_fun.svgz
A	M		tags/sc-actions-tag_fun.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_important.svgz
A	M		tags/sc-actions-tag_important.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_preference_bad.svgz
A	M		tags/sc-actions-tag_preference_bad.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_preference_excellent.svgz
A	M		tags/sc-actions-tag_preference_excellent.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_preference_good.svgz
A	M		tags/sc-actions-tag_preference_good.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_priority_high.svgz
A	M		tags/sc-actions-tag_priority_high.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_priority_low.svgz
A	M		tags/sc-actions-tag_priority_low.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_priority_medium.svgz
A	M		tags/sc-actions-tag_priority_medium.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_progress_000.svgz
A	M		tags/sc-actions-tag_progress_000.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_progress_025.svgz
A	M		tags/sc-actions-tag_progress_025.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_progress_050.svgz
A	M		tags/sc-actions-tag_progress_050.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_progress_075.svgz
A	M		tags/sc-actions-tag_progress_075.svgz.license (3 lines)
A	M	(bin)	tags/sc-actions-tag_progress_100.svgz
A	M		tags/sc-actions-tag_progress_100.svgz.license (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	81247	59f76f2		Apr 26 2020, 2:36 PM	★	★
Diff 2	81251	59f76f2	manueljlin says it is ok to license the icons to LGPL-2.0-or-later so we can…	Apr 26 2020, 2:52 PM	★	★
Diff 3	81271	59f76f2	USE LGPL-2.1-or-later	Apr 26 2020, 6:13 PM	★	★
Diff 4	81277	59f76f2	I should not trust my regex skils anymore :D	Apr 26 2020, 7:32 PM	★	★
Diff 5	81285	4c88eb8	R1050:66436fc19bbff11f192b8179a505a17080d09cec	Apr 26 2020, 8:54 PM	★	★