[GTK Subpage] Hide Breeze Dark for GTK3
ClosedPublic

Authored by gikari on Apr 25 2020, 11:55 AM.

Details

Summary

Given, that Breeze GTK grabs its colors from color scheme and Breeze
Dark doesn't do that creating by that confusion within the users, dark
theme should be hidden from the list of available GTK3 themes.

Keeping dark variant may be useful for other desktop environments where
there is no dynamic recoloring and there aren't any color scheme settings.

CCBUG: 413198

Test Plan

Check if the GTK3 combobox in Application Style > GNOME/GTK Application Style does not have the "Breeze-Dark" option.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gikari created this revision.Apr 25 2020, 11:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 25 2020, 11:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Apr 25 2020, 11:55 AM
cblack accepted this revision.Apr 25 2020, 2:48 PM
This revision is now accepted and ready to land.Apr 25 2020, 2:48 PM

I'd probably like to introduce a custom "should show theme variant" attribute to theme indexes, but this will be fine for now.

This revision was automatically updated to reflect the committed changes.