Differential D29161

General cleanup of basketscene
AcceptedPublic
Actions

Authored by ognarb on Apr 24 2020, 5:47 PM.

Tags

None

Subscribers

Details

Reviewers

Summary

Use nullprt instead of NULL or 0
Fix some deprecation
Remove dead code

Diff Detail

Repository

Branch

updatebasketscene

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25850
Build 25868: arc lint + arc unit

ognarb requested review of this revision.Apr 24 2020, 5:47 PM

ognarb created this revision.

Harbormaster completed remote builds in B25849: Diff 81124.Apr 24 2020, 5:47 PM

ognarb added a reviewer: niccolove.Apr 24 2020, 5:50 PM

Remove unrelated local chaneg

Harbormaster completed remote builds in B25850: Diff 81125.Apr 24 2020, 5:51 PM

Just some things I noticed when having a look at this patch :-)

src/basketscene.cpp
572	Add const for the tagId list, and no space after &
5104	Formatting and use qAsConst(m_modifiedFiles)

Fix formating and qAsConst

Harbormaster completed remote builds in B25891: Diff 81189.Apr 25 2020, 6:22 PM

ognarb marked 2 inline comments as done.Apr 25 2020, 6:22 PM

niccolove accepted this revision.Apr 25 2020, 6:32 PM

This revision is now accepted and ready to land.Apr 25 2020, 6:32 PM

alex added inline comments.Apr 28 2020, 8:03 PM

src/basketscene.cpp
571–572	I meant adding a `const` here ;-)

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (3 lines)
M			src/basketscene.cpp (236 lines)
M			src/noteedit.h (2 lines)

Diff 81125

CMakeLists.txt

Loading...

src/basketscene.cpp

Loading...

src/noteedit.h

Loading...