folderview: port the context menu away from KonqPopupMenu.
ClosedPublic
Actions

Authored by dfaure on Oct 2 2016, 7:19 PM.

Details

Reviewers

hein
broulik

Commits

Summary

Many actions were coming from this code anyway, all that was missing
was:

So this commit loses plugins with KIO < 5.27, but that's probably
not a big deal.

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure retitled this revision from to folderview: port the context menu away from KonqPopupMenu..

dfaure updated this object.

dfaure edited the test plan for this revision. (Show Details)

dfaure added reviewers: broulik, hein.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

+1
killing the copy of libkonq would be sweet, yes

Eike: ping?

Sorry, I had this open in the browser and thought I accepted it, somehow that ball got dropped though.

This revision is now accepted and ready to land.Oct 13 2016, 4:51 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		containments/desktop/plugins/folder/CMakeLists.txt (2 lines)
M		containments/desktop/plugins/folder/foldermodel.h (3 lines)
M		containments/desktop/plugins/folder/foldermodel.cpp (103 lines)
D	M	containments/desktop/plugins/folder/internallibkonq/README_internallibkonq.txt (16 lines)
D	M	containments/desktop/plugins/folder/internallibkonq/konq_popupmenu.h (149 lines)
D	M	containments/desktop/plugins/folder/internallibkonq/konq_popupmenu.cpp (597 lines)
D	M	containments/desktop/plugins/folder/internallibkonq/libkonq_export.h (2 lines)