[applets/weather] Improve UX for selecting a weather station
ClosedPublic

Authored by ngraham on Apr 23 2020, 9:00 PM.

Details

Summary

This patch improves the UX of selecting a weather station by re-implementing it a column
of checkboxes that are visible by default at the top of the window, so that selecting a
weather station is follows the local top-to-bottom flow of the page.

When no weather stations are selected (as it is by default), everything else in the
window is disabled so it's completely obvious what you need to do to proceed.

Test Plan

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 23 2020, 9:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 23 2020, 9:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 23 2020, 9:00 PM
ngraham edited the summary of this revision. (Show Details)Apr 23 2020, 9:00 PM

+1 that hidden flag thing always bugged me

applets/weather/package/contents/ui/config/WeatherStationPicker.qml
66

Perhaps just "Weather Providers:"?

67

How about calendarPluginsRepeater.itemAt(0)

ngraham updated this revision to Diff 81049.Apr 23 2020, 9:07 PM
ngraham marked 2 inline comments as done.

Address review comments

kossebau resigned from this revision.Apr 23 2020, 9:39 PM

No time left over for Plasma currently, sorry,

spstarr added a subscriber: spstarr.EditedApr 24 2020, 5:31 AM

-1 From me, what happens if we have more Weather Providers won't the dialog box be cluttered? If we can sort that out then +1

what happens if we have more Weather Providers won't the dialog box be cluttered?

I wonder how many we actually offer?
Maybe the old way but with a more obvious label could work. Dunno...

-1 From me, what happens if we have more Weather Providers won't the dialog box be cluttered? If we can sort that out then +1

Is that in the cards? Right now we have only four. Even if it goes up to eight, I don't think it's really a problem. The window is quite small and there's room to grow if needed, and this patch is solving a usability issue with the current approach.

spstarr requested changes to this revision.Apr 24 2020, 2:33 PM

Hoping to get back into working on the backend as for how many, well depends how many weather providers will provide free API keys to use, I guess this is ok for now then. +1

This revision now requires changes to proceed.Apr 24 2020, 2:33 PM
spstarr accepted this revision.Apr 24 2020, 2:33 PM
This revision is now accepted and ready to land.Apr 24 2020, 2:33 PM
ndavis added a subscriber: ndavis.Apr 24 2020, 2:35 PM

Can you also make locations show up as you type so that you don't need a search button?

In another patch, sure, I can work on that.

ndavis accepted this revision.Apr 24 2020, 2:37 PM
This revision was automatically updated to reflect the committed changes.