Differential D29142

Add footer support to systray
ClosedPublic
Actions

Authored by niccolove on Apr 23 2020, 8:34 PM.

Details

Reviewers
ngraham
Maniphest Tasks
T10470: Improve the visuals of tray popups
Commits
R120:0f28094f584c: Add footer support to systray
Summary

This adds a footer element that will replace with a possible footer that the contained plasmoid could have, given that they are using a Page.

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
niccolove created this revision.Apr 23 2020, 8:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 23 2020, 8:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Apr 23 2020, 8:34 PM
ngraham added a comment.Apr 24 2020, 6:04 PM

It helps to add a description, Test Plan, and screenshots. Since there are none, I have to guess at what this patch is doing, and I'm not sure if its failure to remove the extra margins around the footer in the Audio applet are due to a missing other patch, or this patch not working.

ngraham added a comment.Apr 24 2020, 6:06 PM

It also helps if your reviewer has applied the correct patch before he leaves a snarky comment. :)

I can see now that this is working properly. But please to add more info into the Description and Test Plan sections so they can become a part of the historical record in the git log.

applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
38

Nothing was using this?

niccolove edited the summary of this revision. (Show Details)Apr 24 2020, 8:56 PM
niccolove edited the test plan for this revision. (Show Details)

Sorry! I'll double check from now on.

applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
38

Nothing

ngraham accepted this revision.Apr 24 2020, 10:25 PM
This revision is now accepted and ready to land.Apr 24 2020, 10:25 PM
ngraham requested changes to this revision.Apr 25 2020, 4:24 AM

Actually this does something funky to the Vaults applet if I open the sound applet first and then switch to Vaults while the popup is still open:

I see some errors in the console:

file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/PlasmoidPopupsContainer.qml:40: TypeError: Cannot read property 'visible' of undefined
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/PlasmoidPopupsContainer.qml:41: TypeError: Cannot read property 'height' of undefined
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/PlasmoidPopupsContainer.qml:44: TypeError: Cannot read property 'visible' of undefined
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/PlasmoidPopupsContainer.qml:45: TypeError: Cannot read property 'height' of undefined
This revision now requires changes to proceed.Apr 25 2020, 4:24 AM
niccolove updated this revision to Diff 81183.Apr 25 2020, 5:12 PM
niccolove edited the summary of this revision. (Show Details)

Fix bars not disappearing when switching to a component without page

niccolove updated this revision to Diff 81184.Apr 25 2020, 5:14 PM

Set height correctly code and more concise code

niccolove added a comment.Apr 25 2020, 5:15 PM

Should work now

ngraham accepted this revision.Apr 26 2020, 3:57 AM
This revision is now accepted and ready to land.Apr 26 2020, 3:57 AM
Closed by commit R120:0f28094f584c: Add footer support to systray (authored by niccolove). · Explain WhyApr 26 2020, 10:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81221

View Options

applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

Loading...
View Options

applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

Loading...