- Group Reviewers
- Maniphest Tasks
- T10470: Improve the visuals of tray popups
- R120:0a7b99bb6ae1: Added plasmoidHeading to clipboard and ported to Page
Thanks! Implementation-wise, I would have re-arranged things a bit to have only one header for the PC3.Page, with the contents changing depending on the page in the stack, rather than your approach of giving each page in the stack its own header, but that works fine too and it's perfectly valid so I'll accept it.
Everything works great. Just one thing: I feel like we need a units.smallSpacing bottom margin underneath the headers for both pages.
That was my first though, but the headings often use variables defined in their files which means that I should have brought everything to be one file or deal with passing variables though files. This felt cleaner and I guess it could scale better to new types of pages.