Port all KRun::runService/runApplication to KIO/ApplicationLauncherJob
ClosedPublic

Authored by dfaure on Apr 23 2020, 9:24 AM.

Details

Summary

And use KNotificationJobUiDelegate in case of errors

Test Plan

Untested other than compilation

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25740
Build 25758: arc lint + arc unit
dfaure created this revision.Apr 23 2020, 9:24 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 23 2020, 9:24 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dfaure requested review of this revision.Apr 23 2020, 9:24 AM
broulik accepted this revision.Apr 23 2020, 9:28 AM
broulik added inline comments.
applets/icon/iconapplet.cpp
354

Just FTR this could also get some KServiceAction treatment

applets/kicker/plugin/appentry.cpp
42

Looks unused now?

applets/kicker/plugin/recentusagemodel.cpp
44

Unused?

This revision is now accepted and ready to land.Apr 23 2020, 9:28 AM
dfaure added inline comments.Apr 23 2020, 9:31 AM
applets/kicker/plugin/appentry.cpp
42

No there's a KRun::run in this file. I only ported runService/runApplication in this commit.

applets/kicker/plugin/recentusagemodel.cpp
44

There's a new KRun in this file.

dfaure closed this revision.Apr 23 2020, 9:31 AM
broulik added inline comments.Apr 23 2020, 9:32 AM
applets/kicker/plugin/appentry.cpp
42

Stupid highlighting, I had Ctrl+F for "KRun" but it didn't highlight int :)