Differential D29116

[applets/batterymonitor] Put the toolbar in the header area
ClosedPublic
Actions

Authored by ngraham on Apr 23 2020, 4:02 AM.

Details

Reviewers
broulik
niccolove
manueljlin
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10470: Improve the visuals of tray popups
Commits
R120:eca2ea2c859d: [applets/batterymonitor] Put the toolbar in the header area
Summary

This patch implements part of the mockup at T10470 by putting the power management
checkbox and settings button in a heading area visually connected to the titlebar.

In the process, I fixed a problem with the power management checkbox to make the layout's
spacing work: the checkbox now has text of its own, instead of living in a mouse area
with a separate label.

Test Plan


Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 23 2020, 4:02 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 23 2020, 4:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 23 2020, 4:02 AM
manueljlin accepted this revision.Apr 23 2020, 1:30 PM
This revision is now accepted and ready to land.Apr 23 2020, 1:30 PM
Closed by commit R120:eca2ea2c859d: [applets/batterymonitor] Put the toolbar in the header area (authored by ngraham). · Explain WhyApr 23 2020, 2:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81002

View Options

applets/batterymonitor/package/contents/ui/PopupDialog.qml

Loading...
View Options

applets/batterymonitor/package/contents/ui/PowerManagementItem.qml

Loading...