This patch ports the Bluetooth applet to use Kirigami.PlaceholderMessage. In the
process, and as a necessary precondition, it also refactors the code to be more
declarative.
Details
- Reviewers
drosca niccolove - Group Reviewers
VDG Plasma - Maniphest Tasks
- T13021: Make placeholder messages consistent
- Commits
- R97:b75f36807ab4: [applet] Port to Kirigami.PlaceholderMessage
Everything still works perfectly and there are no visual changes aside from the message
having the same margins etc as all the other ones now:
Diff Detail
- Repository
- R97 Bluedevil
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
That's the focus state, not the hovered state. If I hit the tab key, focus goes somewhere else. Do you see the same?
Correct, but shouldn't the focus state stop after button press, or when I click away, or at least when I close the applet? Or am I getting the concept of focus wrong?
Well, this is the way we handle focus everywhere in KDE. When you press a focusable button, that button gains focus and retains it even after being pressed.
IMO the only issue here is the super-obvious-bordering-on-overwhelming way we visually show focus, which turns the whole button blue and makes it stand out a bit toomuch (IMO).
This now gives me a tiny icon on the button because this is a Kirigami component using desktop style: