Differential D29109

Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage
ClosedPublic
Actions

Authored by ngraham on Apr 22 2020, 7:51 PM.

Details

Reviewers
broulik
niccolove
cblack
Group Reviewers
VDG
Plasma
Maniphest Tasks
T13021: Make placeholder messages consistent
Commits
R120:f7687b01cade: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage
Summary

The Clipboard and Notifications applets live in plasma-workspace; port them to use
Kirigami.PlaceholderMessage

Test Plan

Clipboard:


Notifications:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 22 2020, 7:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 22 2020, 7:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 22 2020, 7:51 PM
cblack accepted this revision.Apr 23 2020, 6:33 PM
This revision is now accepted and ready to land.Apr 23 2020, 6:33 PM
niccolove accepted this revision.Apr 23 2020, 6:34 PM
Closed by commit R120:f7687b01cade: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage (authored by ngraham). · Explain WhyApr 23 2020, 6:36 PM
This revision was automatically updated to reflect the committed changes.
ngraham added inline comments.Apr 23 2020, 6:55 PM
applets/clipboard/contents/ui/ClipboardPage.qml
81

Can this be enabled: rather than visible:? That's what I did in D29132 and I think it's nicer and more consistent with the mockups.

ngraham added inline comments.Apr 23 2020, 6:56 PM
applets/clipboard/contents/ui/ClipboardPage.qml
81

never mind, wrong patch

Revision Contents
Changeset List

Diff 81034

View Options

applets/clipboard/contents/ui/ClipboardPage.qml

Loading...
View Options

applets/clipboard/contents/ui/Menu.qml

Loading...
View Options

applets/notifications/package/contents/ui/FullRepresentation.qml

Loading...