Icon: improve icon rendering on multi-screen multi-dpi setups
ClosedPublic

Authored by apol on Apr 22 2020, 3:51 PM.

Details

Summary

Prefer the usage of QIcon::pixmap(QWindow*...) overload that will take into account which window it's rendering to.
Otherwise it was assuming we were rendering on the primary screen and it would end up being unpredictable.

Test Plan

All looks correct, if I move emojier from a scaled screen to a non-scaled one, icons re-render properly.

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25705
Build 25723: arc lint + arc unit
apol created this revision.Apr 22 2020, 3:51 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 22 2020, 3:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Apr 22 2020, 3:51 PM
davidedmundson accepted this revision.Apr 22 2020, 8:51 PM
This revision is now accepted and ready to land.Apr 22 2020, 8:51 PM
This revision was automatically updated to reflect the committed changes.