Port BrowsingPage to PlaceholderMessage
ClosedPublic

Authored by ngraham on Apr 21 2020, 3:00 PM.

Details

Summary

While I'm stuck with https://bugs.kde.org/show_bug.cgi?id=420324, I might as well make
the spurious "no network connectivity" message prettier and more standardized by using the
new Kirigami cimponent introduced in D29057.

Depends on D29057

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 21 2020, 3:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 21 2020, 3:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 21 2020, 3:00 PM
ngraham updated this revision to Diff 80783.Apr 21 2020, 4:19 PM

Adjusted to changed icon API (now accepts grouped properties, so use icon.name)

apol accepted this revision.Apr 21 2020, 11:57 PM
This revision is now accepted and ready to land.Apr 21 2020, 11:57 PM
ngraham updated this revision to Diff 80824.Apr 22 2020, 1:20 AM

One last thing: add margins so it can't touch the edges of the view

This revision was automatically updated to reflect the committed changes.